Add more detailed message when no library targets found. #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Might have to update a test or two though. |
|
I updated the tests that check the output. I'm a little stumped about the remaining CI failures - I see mentions of rustdoc v29, though, so I assume that's unrelated? |
|
Huh, a new rustdoc format version must have been released without me noticing... Curious 🤔 I'll fix that, thanks for bringing my attention to it! |
obi1kenobi
approved these changes
Apr 14, 2024
|
Fixing the nightly build is blocked pending a new version of an upstream crate being published. But that's why it's a non-required step in our CI -- we can merge without it. I've fixed the other step that was problematic, so this can merge. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #723