Fix false-positives from target-specific optional features #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a situation where we don't want to look into target-specific dependencies? |
|
By the way, this change doesn't apply to |
epage
reviewed
Feb 20, 2023
src/rustdoc_gen.rs
Outdated
Comment on lines
53
to
55
| for target in manifest.parsed.target.values() { | ||
| dependencies.extend(target.dependencies.clone().into_iter()); | ||
| } |
There was a problem hiding this comment.
How does enabling target-specific dependencies behave when the target isn't being built?
There was a problem hiding this comment.
cargo new targetspecific
cd targetspecific
echo "[target.'cfg(windows)'.dependencies]" >> Cargo.toml
echo 'async-std = { version = "1.6.2", optional = true }' >> Cargo.toml
cargo run --features async-std
It seems to work on a unix machine.
There was a problem hiding this comment.
Seems like that would be a good test to have in the repo documented specifically for this purpose rather than relying only on the third-party reproductions
obi1kenobi
changed the title
obi1kenobi
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369