Add: rules/go_unknown_command for misspelled go commands. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ik1ne
commented
Jul 19, 2019
ik1ne
commented
- Add: rules/go_unknown_command for misspelled go commands.
- Add: tests/test_go_unknown_command which tests match and mismatch case of rules/go_unknown_command.
- Change: Added description of go_unknown_command to README.md.
- Add: tests/test_go_unknown_command which tests match and mismatch case of rules/go_unknown_command. - Change: Added description of go_unknown_command to README.md.
|
So obviously I missed the test for |
…et_new_command method.
nvbn
reviewed
Aug 19, 2019
thefuck/rules/go_unknown_command.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| from thefuck.utils import get_closest, replace_argument | |||
|
|
|||
| _GOLANG_COMMANDS = ( | |||
There was a problem hiding this comment.
Can you please make that list dynamic, like in /~https://github.com/nvbn/thefuck/blob/master/thefuck/rules/gem_unknown_command.py#L17 ?
thefuck/rules/go_unknown_command.py
Outdated
|
|
||
| def match(command): | ||
| return (command.script_parts | ||
| and command.script_parts[0] == "go" |
There was a problem hiding this comment.
It will be better to replace that check with for_app decorator, it helps with things like sudo:
from thefuck.utils import for_app
@for_app('go')
def match(command):
...
|
Done. |
|
Awesome, thanks! |
scorphus
added a commit
to scorphus/thefuck
that referenced
this pull request
Jul 29, 2021
scorphus
added a commit
that referenced
this pull request
Aug 1, 2021
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
* - Add: rules/go_unknown_command for misspelled go commands. - Add: tests/test_go_unknown_command which tests match and mismatch case of rules/go_unknown_command. - Change: Added description of go_unknown_command to README.md. * Add: test_get_new_command for testing rules.go_unknown_command.test_get_new_command method. * Change: go_unknown_command.match now uses for_app decorator. * Add: get_golang_commands which dynamically gets golang possible commands. * Fix: cache proper function instead of its result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.