Some improvements #846
Some improvements #846
Conversation
Inspired by Brett Cannon's advise [1].
1: https://snarky.ca/how-to-use-your-project-travis-to-help-test-python-itself/
| @@ -420,7 +422,8 @@ rule with lower `priority` will be matched first; | |||
| * `THEFUCK_HISTORY_LIMIT` – how many history commands will be scanned, like `2000`; | |||
| * `THEFUCK_ALTER_HISTORY` – push fixed command to history `true/false`; | |||
| * `THEFUCK_WAIT_SLOW_COMMAND` – max amount of time in seconds for getting previous command output if it in `slow_commands` list; | |||
| * `THEFUCK_SLOW_COMMANDS` – list of slow commands, like `lein:gradle`. | |||
| * `THEFUCK_SLOW_COMMANDS` – list of slow commands, like `lein:gradle`; | |||
| * `THEFUCK_NUM_CLOSE_MATCHES` – maximum number of close matches to suggest, like `5`. | |||
There was a problem hiding this comment.
Should we just switch to putting a ; on the last line (instead of .), so the diff can be smaller going forward?
There was a problem hiding this comment.
I had the exact same thought. But the next thought was "Wait. It's text, not code". Perhaps it makes sense to have a period there. For me it will look like an unfinished list.
There was a problem hiding this comment.
Hmm yeah, that makes sense too. Alternatively, since we already have the bullet points, maybe it makes sense to remove the semicolon/period entirely? Obviously this would be a separate change.
There was a problem hiding this comment.
I believe that's a good one, reasonable change. 👍
There was a problem hiding this comment.
Thanks, I'll wait until this is closed to make that change (if I remember)
There was a problem hiding this comment.
@josephfrazier I think it should be ok to remove ;, as it's not required by grammar rules
|
Thanks for the review, @josephfrazier! "Rebase and merge", absolutely! I also prefer it :-) |
|
Oh, let me add some tests to |
scorphus
force-pushed
the
sudoless-build
branch
from
a425464 to
01c015b
Compare
|
Diff is huge, thanks 😀! |
* nvbn#833: do not require sudo on TravisCI * #N/A: Add Python dev releases to TravisCI pipeline Inspired by Brett Cannon's advise [1]. 1: https://snarky.ca/how-to-use-your-project-travis-to-help-test-python-itself/ * nvbn#837: try and kill proc and its children * #N/A: show shell information on `thefuck --version` * #N/A: omit default arguments to get_close_matches * nvbn#842: add settings var to control number of close matches * #N/A: remove `n` from the list of `get_closest`'s args
Please don't merge yet. I'd like these changes to be reviewed. Once it's all good I'll push to master. Thanks!