Conda #1138
Merged
Conda #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scorphus
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Spot on, @cjmartian! 👍
Nit: for sake of consistency — and some additional features attached — how about using@for_app("coda")? I also suggested consistent quoting
edit: Sorry for the late review
|
@scorphus No worries, I know we are all busy. I made those changes, cheers! |
scorphus
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Thanks for applying the changes earlier, @cjmartian.
There's one last thing, check the the most recent comment regarding for_app. I'll go ahead and apply that suggestion :-)
|
Thanks, @cjmartian 👍 |
|
Thanks for that last commit, I see what you mean now. Thanks for merging @scorphus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds conda to the list of rules.