Fix get_anomaly_score_losses in dfencoder to work without categorical features
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsin-c
changed the title
fit in dfencoder to work without categorical features
hsin-c
changed the title
fit in dfencoder to work without categorical featuresget_anomaly_score_losses in dfencoder to work without categorical features
mdemoret-nv
approved these changes
Apr 20, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
fit(get_anomaly_score_losses) function in dfencoder encounters an error when no categorical feature is present in the feature set. This PR adds the necessary checks inget_anomaly_score_lossesto ensure the code runs with or without categorical features.Fixes #858
Checklist