Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dfencoder to morpheus repo #763

Merged
merged 101 commits into from
Mar 23, 2023
Merged

Migrate dfencoder to morpheus repo #763

merged 101 commits into from
Mar 23, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Mar 15, 2023 •
edited
Loading

  • Copy dfencoder code, ensuring correct copyright headers
  • Add a manual_seed helper method, replacing duplicated code
  • Add tests for dfencoder
  • Insert both our Apache license, and the original author's BSD license in each of the 4 python files (and the __init__.py). The original code didn't have that, but this conforms with our other 3rd party code inclusions.
  • Transfer compiled C++ tests and libs (fixes [BUG]: C++ tests not being run in CI #765)

fixes #753

@dagardner-nv
Copy files as-is from /~https://github.com/nv-morpheus/dfencoder @ bba45b6
53da129
@dagardner-nv
Insert Apache CR header, along with the original license
b5dd565
@dagardner-nv
Original license file for dfencoder
fd22899
@dagardner-nv
Remove dfencoder dep
a76367d
@dagardner-nv
Find/replace dfencoder imports
2956212
@dagardner-nv
Update CI containers to ensure dfencoded isn't installed and prevent …
2a5d7bd 
…tests from accidentally passing due to presence of old package
@dagardner-nv
First pass at tests for dfencoder
08053d0
@dagardner-nv
wip
dbeb1d8
@dagardner-nv
wip
57423ed
@dagardner-nv
more tests
aeca28f
@dagardner-nv
Tests for NullScaler
927bfff
@dagardner-nv
Consolidate duplicated random seeding code into a single utility func…
4315d16 
…tion
@dagardner-nv
Tests for dfencoder's EncoderDaraframe
75adf73
@dagardner-nv
wip
7b8f1c9
@dagardner-nv
Fix missing attribute error for default value of interpret_activation…
d386f6c 
… method
@dagardner-nv
Remove unused imports
f39702c
@dagardner-nv
manual_seed fixture needs to be per-function so that tests are not im…
4e71cdc 
…pacted by execution order
@dagardner-nv
Explicit fixture usage
8c441ae
@dagardner-nv
tests for CompleteLayer class
29d3fd4
@dagardner-nv
wip
a0c924e
@dagardner-nv
Merge branch 'branch-23.03' into david-migrate-dfencoder
28701b9
@dagardner-nv
Fix bad copy/paste
ed48a03
@dagardner-nv
wip
7664657
@dagardner-nv
Test for get_scaler
46c5501
@dagardner-nv
Make a fixture for reading the most commonly used test file into a da…
7b15ce0 
…taframe
@dagardner-nv
Add test for init_numeric
67a5417
@dagardner-nv
Add comment about poorly named attribute
95f0dcb
@dagardner-nv
wip
ca4bc74
@dagardner-nv
Document num_names attribute
95622d6
@dagardner-nv
wip
1f3c8c1
mdemoret-nv
mdemoret-nv approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for dfencoder look great. Exactly what we need for unit tests. Quite a few comments but I'm approving since they are all straightforward.

@dagardner-nv
Sort imports
2c0f2e5
@dagardner-nv
Merge branch 'branch-23.03' into david-migrate-dfencoder [no ci]
3c047c5
@dagardner-nv
Add comment with issue on removing dfencoder
aef972a
@dagardner-nv
Rename df fixture to filter_probs_df
3d79e76
@dagardner-nv
Rename dfencoder_tests to dfencoder [no ci]
01c95ac
@dagardner-nv
Merge branch 'branch-23.03' into david-migrate-dfencoder [no ci]
2b343e1
@dagardner-nv
Replace overloaded df_type fixture with marks [no ci]
729680f
@dagardner-nv
df fixture now uses the filter_probs_df ficture removing some duplica…
945d336 
…ted code, revert change to yields
@dagardner-nv
Fix bad copy/paste
6c4033a
@dagardner-nv
Merge branch 'branch-23.03' into david-migrate-dfencoder
f7c99c8
@dagardner-nv
Document the manual_seed fixture and yield the seed function
577ca06
@dagardner-nv
Don't import cudf, import annotations from future allowing cudf to st…
da3e85e 
…ill appear in type-hints
@dagardner-nv
Importing annotations from __future__ not fully supported, and not by…
da49c78 
… flake8/pyflakes
@dagardner-nv dagardner-nv mentioned this pull request Mar 22, 2023
Merged
mdemoret-nv
mdemoret-nv approved these changes Mar 23, 2023
View reviewed changes
@dagardner-nv
Copy link
Contributor Author

/merge

1 similar comment
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 33e922c into nv-morpheus:branch-23.03 Mar 23, 2023
@dagardner-nv dagardner-nv deleted the david-migrate-dfencoder branch March 23, 2023 22:49
rapids-bot bot pushed a commit that referenced this pull request Mar 24, 2023
@dagardner-nv
End-to-end dfencoder test (#777)
9e4065f 
* Adds @hsin-c's end-to-end test script to our unittests along with associated data
* New data file signed-off by @BartleyR 

Requires #763 to be merged first

Authors:
  - David Gardner (/~https://github.com/dagardner-nv)
  - Michael Demoret (/~https://github.com/mdemoret-nv)

Approvers:
  - Bartley Richardson (/~https://github.com/BartleyR)
  - Michael Demoret (/~https://github.com/mdemoret-nv)

URL: #777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: C++ tests not being run in CI Migrate dfencoder into the Morpheus repo
2 participants
@dagardner-nv @mdemoret-nv