-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Rapids 25.02 and CUDA 12.8 #2183
Adopt Rapids 25.02 and CUDA 12.8 #2183
Conversation
…rpheus into david-25.02-x-25.02
…avid-25.02-x-25.02
…avid-rapids-25.02
…avid-rapids-25.02
…avid-rapids-25.02
…mount for apt, pip and conda
/ok to test |
Cleanup DOCA env vars Remove redundant calls to `apt update`, remove call to `apt upgrade`. Fix download location for `doca-host.deb` Consolidate installing of doca packagwes
/ok to test |
/ok to test |
/ok to test |
1 similar comment
/ok to test |
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the source code changes but a deeper look at CI/Dockerfiles should be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added notes for DOCA are nice -- hopefully reduces future hair-pulling.
Overall, everything here LGTM 👍
/merge |
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA. * Install DOCA from an apt repository rather than downloading a deb file * Avoid a version conflict for the `mft` package by manually specifying the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo. * Incorporates changes from nv-morpheus#2097 to `cudf_helpers.pyx` to match changes made to cudf. Closes nv-morpheus#2182 - I am familiar with the [Contributing Guidelines](/~https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (/~https://github.com/dagardner-nv) - Matthew Roeschke (/~https://github.com/mroeschke) Approvers: - Michael Demoret (/~https://github.com/mdemoret-nv) - Will Killian (/~https://github.com/willkill07) URL: nv-morpheus#2183
Description
MORPHEUS_CUDA_ARCHITECTURES
to just those supported by DOCA.mft
package by manually specifying the version ofmft
to ensure the package is installed from the DOCA repo and not the CUDA repo.cudf_helpers.pyx
to match changes made to cudf.Closes #2182
By Submitting this PR I confirm: