Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Rapids 25.02 and CUDA 12.8 #2183

Merged
merged 35 commits into from
Feb 19, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 13, 2025

Description

  • When building with DOCA in CI restrict the MORPHEUS_CUDA_ARCHITECTURES to just those supported by DOCA.
  • Install DOCA from an apt repository rather than downloading a deb file
  • Avoid a version conflict for the mft package by manually specifying the version of mft to ensure the package is installed from the DOCA repo and not the CUDA repo.
  • Incorporates changes from Move cudf helper dtype_from_column_view import from type to column #2097 to cudf_helpers.pyx to match changes made to cudf.

Closes #2182

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

mroeschke and others added 26 commits January 9, 2025 11:59
@dagardner-nv dagardner-nv added dependencies Pull requests that update a dependency file non-breaking Non-breaking change feature request New feature or request conda-build Enables running the conda-build step on a PR labels Feb 13, 2025
@dagardner-nv dagardner-nv self-assigned this Feb 13, 2025
@dagardner-nv dagardner-nv requested review from a team as code owners February 13, 2025 16:22
Copy link

copy-pr-bot bot commented Feb 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv
Copy link
Contributor Author

/ok to test

Cleanup DOCA env vars
Remove redundant calls to `apt update`, remove call to `apt upgrade`.
Fix download location for `doca-host.deb`
Consolidate installing of doca packagwes
@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

1 similar comment
@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv dagardner-nv changed the title Adopt Rapids 25.02 / CUDA 12.8 Adopt Rapids 25.02 and CUDA 12.8 Feb 14, 2025
@dagardner-nv
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the source code changes but a deeper look at CI/Dockerfiles should be done

Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added notes for DOCA are nice -- hopefully reduces future hair-pulling.

Overall, everything here LGTM 👍

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e80ba4d into nv-morpheus:branch-25.06 Feb 19, 2025
16 checks passed
willkill07 pushed a commit to dagardner-nv/Morpheus that referenced this pull request Feb 21, 2025
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA.
* Install DOCA from an apt repository rather than downloading a deb file
* Avoid a version conflict for the `mft` package by manually specifying  the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo.
* Incorporates changes from nv-morpheus#2097 to `cudf_helpers.pyx` to match changes made to cudf.

Closes nv-morpheus#2182

- I am familiar with the [Contributing Guidelines](/~https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (/~https://github.com/dagardner-nv)
  - Matthew Roeschke (/~https://github.com/mroeschke)

Approvers:
  - Michael Demoret (/~https://github.com/mdemoret-nv)
  - Will Killian (/~https://github.com/willkill07)

URL: nv-morpheus#2183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR dependencies Pull requests that update a dependency file feature request New feature or request non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Adopt Rapids 25.02 / CUDA 12.8
4 participants