-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ControlMessage output in the C++ impl of DeserializeStage #1478
Merged
rapids-bot
merged 48 commits into
nv-morpheus:branch-24.03
from
dagardner-nv:david-deserialize-control-message-1328
Feb 12, 2024
Merged
Support ControlMessage output in the C++ impl of DeserializeStage #1478
rapids-bot
merged 48 commits into
nv-morpheus:branch-24.03
from
dagardner-nv:david-deserialize-control-message-1328
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drobison00
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I would like to hold off until the vdb_upload PR goes in.
…two different init methods [no ci]
…avid-deserialize-control-message-1328
…an assert if the gil isn't held when its called, MessageMeta::get_column_names shouldn't assume the gil is held
…agardner-nv/Morpheus into david-deserialize-control-message-1328
mdemoret-nv
approved these changes
Feb 12, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeserializeStage
now templates the output message typeMessageMeta
to the C++ instance ofMessageMeta
. This removes the need to explicitly import the C++ impl ofMessageMeta
in order to set the payload of aControMessage
.WebScraperStage
andRSSController
show_warning_message
now marked visible in libtests/test_deserialize_stage_pipe.py
->tests/stages/test_deserialize_stage_pipe.py
&tests/test_message_meta.py
->tests/messages/test_message_meta.py
Closes #1328
Closes #1480
Closes #1481
Closes #1342
By Submitting this PR I confirm: