Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Deprecate ResponseMemoryProbs & MultiResponseProbsMessage in favor of ResponseMemory & MultiResponseMessage #697

Closed
2 tasks done
dagardner-nv opened this issue Feb 13, 2023 · 0 comments · Fixed by #711
Closed
2 tasks done

[FEA]: Deprecate ResponseMemoryProbs & MultiResponseProbsMessage in favor of ResponseMemory & MultiResponseMessage #697

dagardner-nv opened this issue Feb 13, 2023 · 0 comments · Fixed by #711
Assignees
@dagardner-nv
Labels
breaking Breaking change feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

MultiResponseMemoryProbs doesn't do much differently than MultiResponseMemory other than enforce that at least one tensor is named "probs" however we want to be a little more flexible and

This would be a breaking change.

Describe your ideal solution

n/a

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Feb 13, 2023
@dagardner-nv dagardner-nv self-assigned this Feb 13, 2023
@dagardner-nv dagardner-nv added the breaking Breaking change label Feb 13, 2023
@dagardner-nv dagardner-nv changed the title [FEA]: Deprecate ResponseMemoryProbs & MultiResponseMemoryProbs in favor of ResponseMemory & MultiResponseMemoryProbs [FEA]: Deprecate ResponseMemoryProbs & MultiResponseProbsMessage in favor of ResponseMemory & MultiResponseMessage Feb 15, 2023
@dagardner-nv dagardner-nv mentioned this issue Feb 15, 2023
Merged
@jarmak-nv jarmak-nv moved this from Todo to Review in Morpheus Boards Feb 16, 2023
@rapids-bot rapids-bot bot closed this as completed in #711 Mar 21, 2023
rapids-bot bot pushed a commit that referenced this issue Mar 21, 2023
@dagardner-nv
Deprecate ResponseMemoryProbs & MultiResponseProbsMessage (#711)
940cd8c 
* Log a deprecation warning from the constructor for `ResponseMemoryProbs` & `MultiResponseMemoryProbs`
* Replace usage of `ResponseMemoryProbs` with `ResponseMemory`
* Replace usage of `MultiResponseProbsMessage` with `MultiResponseMessage`
* `AddClassificationsStage` and `AddScoresStage` now accept an optional `output_name="probs"` constructor argument.
* *breaking* Any custom stages which only return `MultiResponseMemoryProbs` from the `accepted_types` method will fail during pipeline build.
* Includes changes in PR #655


fixes #697

Authors:
  - David Gardner (/~https://github.com/dagardner-nv)
  - Michael Demoret (/~https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (/~https://github.com/mdemoret-nv)

URL: #711
@github-project-automation github-project-automation bot moved this from Review to Done in Morpheus Boards Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
breaking Breaking change feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate ResponseMemoryProbs & MultiResponseProbsMessage dagardner-nv/Morpheus
1 participant
@dagardner-nv