Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determination of chocolatey #1616

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

mazharenko
Copy link
Contributor

This addresses #1614

@CharliePoole CharliePoole merged commit 060d480 into nunit:main Jan 31, 2025
3 checks passed
@CharliePoole
Copy link
Member

@mazharenko Thanks for the fix!

It was obviously correct by inspection, so I merged it. Please verify it in your environment by installing from our MyGet feed. Version is 3.19.2-alpha.2. Unfortunately, our post-packaging tests only simulate installation under Chocolatey, which is why this problem escaped notice. I'll have to think about finding a way to actually use chocolatey in our CI builds, but that will take a bit of time.

Once you have verified that this works, I'll queue it up for including in 3.19.2

@mazharenko
Copy link
Contributor Author

mazharenko commented Jan 31, 2025

@CharliePoole Thank you! I can confirm that my tests now run once I upgraded nunit-console-runner from your chocolatey feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants