Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new playlist button on Playlists screen #1029

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Create new playlist button on Playlists screen #1029

merged 1 commit into from
Aug 4, 2021

Conversation

ReshetovItsMe
Copy link
Contributor

This PR addresses issue #999 to create playlist from playlists screen

It involves the following changes:

  • Translation for new buttons
  • PlaylistHeader added dialog and button to create playlist
  • Playlist helper in core now can formatPlaylistForStorage with empty tracks
  • PlaylistContainer hook pass createPlaylist action
  • Updated snapshots

Looks like this:
new playlist

@haidang666 haidang666 linked an issue Jul 27, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1029 (d738b1c) into master (478602a) will increase coverage by 0.20%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   60.78%   60.98%   +0.20%     
==========================================
  Files         273      273              
  Lines        4786     4791       +5     
  Branches      306      307       +1     
==========================================
+ Hits         2909     2922      +13     
+ Misses       1617     1610       -7     
+ Partials      260      259       -1     
Impacted Files Coverage Δ
packages/app/app/components/InputDialog/index.js 89.47% <0.00%> (-5.27%) ⬇️
packages/app/app/actions/playlists.ts 56.52% <100.00%> (+12.23%) ⬆️
...app/components/Playlists/PlaylistsHeader/index.tsx 100.00% <100.00%> (ø)
packages/app/app/components/Playlists/index.tsx 93.33% <100.00%> (ø)
...ges/app/app/containers/PlaylistsContainer/hooks.ts 87.50% <100.00%> (+1.78%) ⬆️
packages/core/src/helpers/playlist/index.ts 19.23% <100.00%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478602a...d738b1c. Read the comment docs.

<Icon name='file text' />
{t('import-button')}
</Button>
<div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of this div

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I can't because header has flex with space between

@nukeop nukeop merged commit 551da38 into nukeop:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button to create an empty one though on the playlist screen
2 participants