Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NucleosDompdfExtension.php Extension Injection #553

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Update NucleosDompdfExtension.php Extension Injection #553

merged 5 commits into from
Aug 14, 2024

Conversation

Kitee666
Copy link
Contributor

@Kitee666 Kitee666 commented Aug 8, 2024

Fix for Symfony 7.1

After upgrading to Symfony 7.1 I encountered a deprecation notice on your bundle.

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice.

@core23 core23 added this to the 4.3.0 milestone Aug 8, 2024
@core23
Copy link
Member

core23 commented Aug 8, 2024

Can you please run php-cs-fixer

@Kitee666
Copy link
Contributor Author

Kitee666 commented Aug 8, 2024

Sure, sorry I forgor 😄
I'll do that as soon as I come back to work.

@Kitee666
Copy link
Contributor Author

Kitee666 commented Aug 9, 2024

#495f717 have only php-cs-fixer fixes in extension files.
#43787e7 have "fixes" to other files after running php-cs-fixer in project
#6b0723b is just minor addition to composer with added "^7.1" at every symfony package.
I think I am just messing something up but I am not really sure what :(

*insert pejczowanie*
@Kitee666
Copy link
Contributor Author

Sorry, I am kinda new to open source contributions. I usually work on my own projects or collaborate with in-domain developers;
I hope it will work this time 😄

@core23 core23 merged commit 9d0329f into nucleos:4.3.x Aug 14, 2024
14 checks passed
@core23
Copy link
Member

core23 commented Aug 14, 2024

Thanks @Kitee666 🚀

@Kitee666
Copy link
Contributor Author

I am happy that I could help a little 😊
Thank you @core23 for creating this package!

@Kitee666 Kitee666 deleted the fix/symfony71/dependency-injection branch August 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants