-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight collectible resources, take 2 #37
Merged
nucleartide
merged 26 commits into
master
from
jason/highlight-collectible-resources-take-2
Mar 22, 2023
Merged
Highlight collectible resources, take 2 #37
nucleartide
merged 26 commits into
master
from
jason/highlight-collectible-resources-take-2
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job Story
Notion
Development Checklist
Files changed
and revise anything that needs to be cleaned up.Quality Assurance Checklist
Screen Recording
Untitled.mov
Changelog
PlayerCollectableRadius
script that checks for collectibles within range, and highlights themHow it works
This pull request adds a “signifier” for in-game resources that are collectible by the player.
In other words, the game will now outline (in green) nearby resources that can be collected.
The resource that the player is facing directly will also display an “E” text overlay, to signify that you can press “E” on your keyboard to collect the resource.
The work for this pull request took a lot longer than I expected. There were a couple of phases of work:
Though it took awhile, I’m glad that I’m now familiar with Unity’s URP, and that this pull request process is becoming more effective at enforcing quality.
Creating “signifiers” for future user stories should be a lot faster.
Final Checklist