deps: upgrading @actions/github to 6.0.0
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Despite it passing, the build CI has some interesting warnings about mocks not being called:
/~https://github.com/npm/action-deploy/actions/runs/9619410439/job/26535455926?pr=65
If we decide to continue to maintain this public action, we should possibly add a .nvmrc file and have the build job call setup-node.
This was referenced Jun 24, 2024
shmam
added a commit
to npm/action-deployment-notifications
that referenced
this pull request
Jun 25, 2024
* fix dependabot alerts (npm#57) * nock 13.5.1 * Revert "nock 13.5.1" This reverts commit dd1d7ad. * mock commit * Revert "mock commit" This reverts commit 10c7bab. * @zeit/ncc replaced by @vercel/ncc * nock 13.5.4 * typescript 3.9.7 * ts-standard 12.0.2 * ts-jest 26.5.6 * @types/node 17.0.41 * @types/jest 27.4.1 * @typescript-eslint/parser 7.1.1 * @types/sinon 17.0.3 * js-yaml 4.1.0 * @types/node and typescript * jest 26.6.3 * typescript code cleanup * jest and related * jest 28.1.3 * jest-circus and sinon * typescript 4.9.5 * @slack/web-api 7.0.2 * @actions/core 1.6.0 * reverting console.error * version bump * deps: upgrading `@actions/github` to 6.0.0 (npm#65) * deps: upgrading @actions/github to 6.0.0 which included a pretty big re-write * 2.6.0 * updating dist * fix: pre version bump * 2.6.0 --------- Co-authored-by: Jithin Prabhakaran Girija <141764922+jpg619@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrading
@actions/githubto this latest major version to address the lodash dependency vuln required a rewrite of how we used the client. It also required introducing babel to transform the dependency@octokit/corein order to run tests. Mocking has to be completely re-done as well to account for the new ways that octokit was using built-in fetch.References