Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Event::kind serialization with serialization-compat-6 #660

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Dec 17, 2024

The kind field in Event was serialized as type in v6, but is kind with serialization-compat-6 feature

Reference: tauri-apps/plugins-workspace#2221

I'm not sure how the release process work here, let me know if I need to add a change log entry (if so please also tell me what version should this change be in, since I see there's already a notify-types 2.0.0 (unreleased) entry) or do I need to target another branch

@dfaust
Copy link
Member

dfaust commented Dec 17, 2024

Thank you for the fix.
I'll merge it into main and create a new branch based on the last tag and then cherry-pick this commit.

@dfaust dfaust merged commit a04a52c into notify-rs:main Dec 17, 2024
1 check passed
@Legend-Master Legend-Master deleted the fix-serialization-compat-6 branch December 18, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants