Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DebouncedEvent to debouncer-full #488

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

dfaust
Copy link
Member

@dfaust dfaust commented May 28, 2023

Emit events in the debouncer-full as DebouncedEvents, each containing the original notify event and the time at which it occurred.

Having access to the time at which the event occurred is useful when handling situations in which the application writes to the file system and has to ignore the resulting events within a certain time frame.

@dfaust dfaust force-pushed the debounced-event branch from c3100ad to 23e3c88 Compare May 28, 2023 13:22
@0xpr03
Copy link
Member

0xpr03 commented May 28, 2023

LGMT, ping me when you're ready

@chipsenkbeil
Copy link

@dfaust can this get merged? Timestamps would be really handy for my use case (integrating with an editor that writes to watched files). Is there anything blocking this now? 😄

@dfaust
Copy link
Member Author

dfaust commented Jun 8, 2023

@dfaust can this get merged?

Yes, I haven't found any issues and haven't made any changes.

@0xpr03 0xpr03 merged commit 58a4c13 into notify-rs:main Jun 9, 2023
@0xpr03
Copy link
Member

0xpr03 commented Jun 15, 2023

Published

@dfaust dfaust deleted the debounced-event branch June 16, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants