Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-sys to 0.48 #479

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Apr 26, 2023

No description provided.

@0xpr03
Copy link
Member

0xpr03 commented Apr 26, 2023

Thanks, but I think we'll wait for now. See #473. I'm waiting for this to develop further than some "cosmetic" changes of where the imports are. There is already 0.49..

@complexspaces
Copy link

complexspaces commented Jun 16, 2023

Hi there, has there been any more thinking on this point in the last few months? It seems like the windows ecosystem totals to providing 3 options now:

  • windows-sys, like what notify is currently using.
  • windows-bindgen, which is what the previously attempted PR wanted to introduce in some form.
  • windows-target for manually declaring bindings but still getting proper import resolution.

We're currently trying to consider a windows ecosystem upgrade and Notify is in-tree for us. Most crates seem to be settled onto 0.48 at the time of posting this (Tokio and Mio being the largest ones).

@0xpr03
Copy link
Member

0xpr03 commented Jun 21, 2023

In general we can upgrade to 0.48
What I do want to prevent is having weekly upgrades for changes in the windows crates that are purely syntactical (the bindings themselves don't change for us), introducing a lot of noise.

In terms of code size this shouldn't affect anyone, as LTO should remove everything that isn't used, and the bindings are not big.

There is probably also a debate to be had about windows-sys vs windows-bindgen vs windows of notify vs debouncer-full

@0xpr03 0xpr03 added this to the 6.1.0 milestone Jun 21, 2023
@0xpr03 0xpr03 force-pushed the windows-sys_0.48 branch from c480784 to 55339ba Compare August 8, 2023 16:21
@0xpr03 0xpr03 merged commit 22f84ca into notify-rs:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants