Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StreamContextInfo to be Send #325

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Fix StreamContextInfo to be Send #325

merged 3 commits into from
Jun 2, 2021

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Jun 2, 2021

In #324, we found that we were passing StreamContextInfo to another thread, even though the type is not actually Send. This makes sure that StreamContextInfo is actually Send by wrapping it in a mutex.

Fixes #324

erickt added 2 commits June 2, 2021 10:40
In notify-rs#324, we found that we were passing StreamContextInfo to another
thread, even though the type is not actually Send.

Fixes notify-rs#324
src/fsevent.rs Outdated Show resolved Hide resolved
@0xpr03 0xpr03 merged commit 0b3e313 into notify-rs:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soundness Bug - StreamContextInfo is not safe to send across threads
2 participants