Address findings from migration testing #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
approved these changes
Oct 30, 2024
pmarkowsky
pushed a commit
to pmarkowsky/nps-santa
that referenced
this pull request
Nov 3, 2024
This PR adds additional cleanup for two cases: 1. Upgrading from NPS Santa to NPS Santa The `com.northpolesec.santa.migration.plist` launch daemon artifact was being left on disk. This was due to tamper protections preventing the deletion on installation of the upgraded version. While benign, it's not ideal to leave the artifact on disk. This file is now removed. 2. When Google Santa is attempted to be installed over NPS Santa, the `com.google.santa.newsyslog.conf` artifact was not cleaned up. During discussion, we decided it would be best that instead of always attempting to remove this file, we should instead mv the contents to the new `com.northpolesec.santa.newsyslog.conf` path. This will help NPS deployments maintain the same configuration as the previous deployments in the rare event any changes to this file were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional cleanup for two cases:
Upgrading from NPS Santa to NPS Santa
The
com.northpolesec.santa.migration.plistlaunch daemon artifact was being left on disk. This was due to tamper protections preventing the deletion on installation of the upgraded version. While benign, it's not ideal to leave the artifact on disk. This file is now removed.When Google Santa is attempted to be installed over NPS Santa, the
com.google.santa.newsyslog.confartifact was not cleaned up.During discussion, we decided it would be best that instead of always attempting to remove this file, we should instead mv the contents to the new
com.northpolesec.santa.newsyslog.confpath. This will help NPS deployments maintain the same configuration as the previous deployments in the rare event any changes to this file were made.