Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial revert: installer: support side-by-side install of NPS Santa [1/2] #27

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tburgin
Copy link
Contributor

@tburgin tburgin commented Oct 11, 2024

This is a partial revert of 338da35. It keeps the :package-dev rule, but reverts installing as Santa_NPS.app.

Rebase once #26 lands.

@tburgin tburgin requested a review from a team as a code owner October 11, 2024 12:47
@tburgin tburgin added the build Issues or PRs related to the build infrastructure label Oct 11, 2024
russellhancox
russellhancox previously approved these changes Oct 11, 2024
mlw
mlw previously approved these changes Oct 11, 2024
@tburgin tburgin dismissed stale reviews from mlw and russellhancox October 11, 2024 13:56

The merge-base changed after approval.

@tburgin tburgin force-pushed the revert-Santa_NPS.app branch from bb7c2af to cf93983 Compare October 11, 2024 13:56
@tburgin tburgin enabled auto-merge (squash) October 11, 2024 13:56
@tburgin tburgin merged commit 6433869 into northpolesec:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues or PRs related to the build infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants