-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
santactl/fileinfo: Add --entitlements flag and key. #263
Conversation
Entitlements will be printed if `--entitlement` is passed as a flag or if `Entitlements` is in the list of requested keys.
This is showing up as mostly JSON for me. Entitlements : {
"com.apple.application-identifier" = "ZMCG7MLDV9.com.northpolesec.santa";
"com.apple.developer.system-extension.install" = 1;
"com.apple.developer.team-identifier" = ZMCG7MLDV9;
"keychain-access-groups" = (
"ZMCG7MLDV9.com.northpolesec.santa"
);
} Why not format this like the signing chain with the list being ordered as key value pairs to match the other items when not using --json? E.g. Entitlements :
1. "com.apple.application-identifier": "ZMCG7MLDV9.com.northpolesec.santa"
2. "com.apple.developer.system-extension.install": "1"
3. "com.apple.developer.team-identifier" : "ZMCG7MLDV9"
4. "keychain-access-groups" : ["ZMCG7MLDV9.com.northpolesec.santa"] |
Keeping things interesting, we have a slightly different format for bundle hashes - they're not numbered:
I think I agree it makes sense to display things a tad bit nicer in non-JSON output. Though we will still hit some issues with nested k/v pairs and we probably shouldn't try too hard there... As to whether or not we number, I don't care - it'd be nice to be consistent eventually though |
Done. Other than parsing true/false values I'm not attempting to do anything with the value so there can still be JSON output in complex cases. E.g.
|
I've added numbers to the binaries included in the bundle hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Entitlements will be printed if
--entitlements
is passed as a flag or ifEntitlements
is in the list of requested keys.