Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: Add simple Makefile #229

Merged
merged 1 commit into from
Jan 28, 2025
Merged

project: Add simple Makefile #229

merged 1 commit into from
Jan 28, 2025

Conversation

russellhancox
Copy link
Member

The Makefile just wraps existing commands so we can run make to auto-format and build before doing a PR instead of running multiple commands.

@russellhancox russellhancox requested a review from a team as a code owner January 27, 2025 22:00
@github-actions github-actions bot added comp/santad Issues or PRs related to the daemon comp/gui Issues or PRs related to the Santa GUI comp/common size/s Size: small labels Jan 27, 2025
@pmarkowsky
Copy link
Contributor

What about making rule or sh_binary target that does all of this or using something like rules_multirun

I'll admit to being a little hesitant to add yet another build tool on top a build tool.

Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

After talking about this. This seems like the easiest path for us to get what we want.

@russellhancox russellhancox merged commit 4696a11 into main Jan 28, 2025
10 checks passed
@pmarkowsky pmarkowsky deleted the rah/makefile branch January 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/common comp/gui Issues or PRs related to the Santa GUI comp/santad Issues or PRs related to the daemon size/s Size: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants