Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwards compatibility with string_view proto descriptor names #206

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gnoack
Copy link
Contributor

@gnoack gnoack commented Jan 14, 2025

Descriptor names can be returned as string_view in the future, so they should be concatenated with absl::StrCat() instead of "+".

See https://protobuf.dev/news/v30/#descriptor-apis ("Descriptor APIs")

Descriptor names can be returned as string_view in the future,
so they should be concatenated with absl::StrCat() instead of "+".

See https://protobuf.dev/news/v30/#descriptor-apis ("Descriptor APIs")
@gnoack gnoack requested a review from a team as a code owner January 14, 2025 07:58
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added comp/santad Issues or PRs related to the daemon lang/objc++ PRs modifying files in ObjC++ size/xs Size: extra small labels Jan 14, 2025
@russellhancox russellhancox merged commit ac97782 into northpolesec:main Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/santad Issues or PRs related to the daemon lang/objc++ PRs modifying files in ObjC++ size/xs Size: extra small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants