Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: support side-by-side install of NPS Santa [1/2] #19

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

tburgin
Copy link
Contributor

@tburgin tburgin commented Oct 7, 2024

This CL changes the installer to lay down Santa on disk as Santa_NPS.app. The post install or daemon will rename Santa_NPS.app to Santa.app when it is safe to do so.

A follow up CL will add logic in the daemon to idle while another install of Santa is running.

To test the installer behavior as new label has been added package-dev, which will package up a dev build. To support this, package.sh is now a separate script that can be called for both release and dev builds.

bazel build :package-dev -c opt

@tburgin tburgin added the build Issues or PRs related to the build infrastructure label Oct 7, 2024
@tburgin tburgin requested a review from a team as a code owner October 7, 2024 13:51
@pmarkowsky pmarkowsky added this to the 2024.10 milestone Oct 7, 2024
Copy link
Contributor Author

@tburgin tburgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@tburgin tburgin merged commit 338da35 into northpolesec:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues or PRs related to the build infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants