Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Use interpolation where needed in strings #180

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

russellhancox
Copy link
Member

This should go at least some of the way to fix Allister's comments in #177.

Also add mode picker in SNTTestGUI to make testing UI changes for different client modes easier.

image

This should go at least some of the way to fix Allister's comments in northpolesec#177.
@russellhancox russellhancox requested a review from a team as a code owner December 18, 2024 03:16
@github-actions github-actions bot added gui size/m Size: medium labels Dec 18, 2024
@github-actions github-actions bot added the comp/santad Issues or PRs related to the daemon label Dec 18, 2024
@russellhancox
Copy link
Member Author

@arubdesu Is this better?

@arubdesu
Copy link
Contributor

Yes, looks good 👍

@russellhancox russellhancox merged commit a802627 into northpolesec:main Dec 18, 2024
10 checks passed
@russellhancox russellhancox deleted the rah/gui-interpolation branch December 18, 2024 16:19
@russellhancox russellhancox added comp/gui Issues or PRs related to the Santa GUI and removed gui labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/gui Issues or PRs related to the Santa GUI comp/santad Issues or PRs related to the daemon size/m Size: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants