Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/release: install dependencies on Linux #52

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

MrAnno
Copy link
Contributor

@MrAnno MrAnno commented Dec 15, 2022

This adds Linux dependencies to the release binary, and also clarifies that these binaries are for glibc 2.31 or higher.

Static linking would have been better, but Ubuntu does not provide fPIC static libraries for Lua, so I ended up implementing this terrible dependency installation method.

@MrAnno
Copy link
Contributor Author

MrAnno commented Dec 15, 2022

TODO: check if we are allowed to upload these binaries without rebuilding them from source

Any redistribution of modified versions of Ubuntu must be approved, certified or provided by Canonical if you are going to associate it with the Trademarks. Otherwise you must remove and replace the Trademarks and will need to recompile the source code to create your own binaries.

I'm not sure our usage counts as a "modified version of Ubuntu".

@norberttak
Copy link
Owner

As far as I understand this sentence is about when somebody wants to create a new Linux distribution using Ubuntu sources. I don't think using one of the libraries in a static linkage (particularly in a GPL license code) is something Canonical worries about.
If you are ready with this PR I can merge it. If they have any objections to it, I can remove it later.

@norberttak norberttak added this to the v1.5 milestone Dec 15, 2022
@MrAnno
Copy link
Contributor Author

MrAnno commented Dec 16, 2022

Dynamic libraries are packaged in this PR with an ORIGIN runpath trick instead of linking statically (I ran into problems with that due to the non-PIC Lua static lib that is supplied by Ubuntu).

But either way, I think we are OK.

@norberttak norberttak merged commit c22e442 into norberttak:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants