Updated to Node 8.11.1 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina ci errored, rerun? |
mafintosh
reviewed
Apr 4, 2018
| var method = keys[v]; | ||
| if (!Duplex.prototype[method]) Duplex.prototype[method] = Writable.prototype[method]; | ||
| { | ||
| // avoid scope creep, the keys array can then be collected |
There was a problem hiding this comment.
this is now a very confusing comment as we rewrite consts/lets to var, but i guess there is nothing to do about that 😂
There was a problem hiding this comment.
all this code is babelified anyway here. So we might even change some of this code in core.
|
LGTM on clean ci |
|
Let's try again, CI: https://ci.nodejs.org/view/MyJobs/job/readable-stream-pipeline/14/ |
|
CI is passing, landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.