Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: formatting release post #6044

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

huynl-96
Copy link
Contributor

@huynl-96 huynl-96 commented Oct 24, 2023

Description

Run prettier before writing release post to file.

Validation

WITH vs WITHOUT prettier format version respectively using diff changes comparison

Screen.Recording.2023-10-24.at.22.45.11.mov
image

Related Issues

Resolves #6041

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@huynl-96 huynl-96 requested a review from a team as a code owner October 24, 2023 15:50
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:59pm

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and quick work! Thank you so much for your first contribution :shipit:

@ovflowd ovflowd added hacktoberfest This Issue is meant for Hacktoberfest 2023 github_actions:pull-request Trigger Pull Request Checks labels Oct 25, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
94.61% (281/297) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 7.224s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your first contribution

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 26, 2023
@ovflowd ovflowd enabled auto-merge October 26, 2023 08:36
@ovflowd ovflowd disabled auto-merge October 26, 2023 08:36
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 26, 2023
@ovflowd ovflowd merged commit 960d704 into nodejs:main Oct 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This Issue is meant for Hacktoberfest 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Prettier as part of the blog post script
4 participants