Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: add undici http tracking support #56488

Merged
merged 1 commit into from
Jan 8, 2025
Merged

inspector: add undici http tracking support #56488

merged 1 commit into from
Jan 8, 2025

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jan 6, 2025 •
edited
Loading

Add basic undici http tracking support via inspector protocol. This
allows tracking fetch calls with an inspector.

Refs: #53946

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 6, 2025 •
edited by legendecas
Loading

Review requested:

  • @nodejs/startup
  • @nodejs/undici
  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 6, 2025
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Jan 6, 2025
@legendecas
inspector: add undici http tracking support
904a6ab 
Add basic undici http tracking support via inspector protocol. This
allows tracking `fetch` calls with an inspector.
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.67456% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (9400eae) to head (904a6ab).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_undici.js 93.61% 9 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #56488    +/-   ##
========================================
  Coverage   88.52%   88.53%            
========================================
  Files         660      661     +1     
  Lines      190887   191062   +175     
  Branches    36631    36653    +22     
========================================
+ Hits       168991   169156   +165     
- Misses      15088    15099    +11     
+ Partials     6808     6807     -1
Files with missing lines Coverage Δ
lib/internal/inspector/network.js 94.44% <100.00%> (+4.12%) ⬆️
lib/internal/inspector/network_http.js 94.69% <100.00%> (ø)
lib/internal/inspector_network_tracking.js 100.00% <100.00%> (ø)
src/node_builtins.cc 78.72% <ø> (+0.23%) ⬆️
lib/internal/inspector/network_undici.js 93.61% <93.61%> (ø)

... and 32 files with indirect coverage changes

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64365/

Ethan-Arrowood
Ethan-Arrowood approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks great. Nice work

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64402/

mcollina
mcollina approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, amazing!

@legendecas legendecas mentioned this pull request Jan 8, 2025
Open
5 tasks
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4f45ace into nodejs:main Jan 8, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4f45ace

@legendecas legendecas deleted the inspector/undici-2 branch January 8, 2025 17:10
@cola119
Copy link
Member

cola119 commented Jan 10, 2025

Thank you!🎉

targos pushed a commit that referenced this pull request Jan 13, 2025
@legendecas @targos
inspector: add undici http tracking support
ef0159b 
Add basic undici http tracking support via inspector protocol. This
allows tracking `fetch` calls with an inspector.

PR-URL: #56488
Refs: #53946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@legendecas @Ceres6
inspector: add undici http tracking support
9e7bc86 
Add basic undici http tracking support via inspector protocol. This
allows tracking `fetch` calls with an inspector.

PR-URL: nodejs#56488
Refs: nodejs#53946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@legendecas @nodejs-github-bot @cola119 @mcollina @jasnell @benjamingr @metcoder95 @Ethan-Arrowood