Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make C++ linter reject template< #20675

Closed
wants to merge 2 commits into from
Closed

tools: make C++ linter reject template< #20675

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This one is more or less just for me. :)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax requested a review from bnoordhuis May 11, 2018 13:45
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 11, 2018
@addaleax addaleax force-pushed the cpplint-template branch from dbc589e to c4d3145 Compare May 11, 2018 13:46
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/18412/

bnoordhuis
bnoordhuis approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. :-)

@addaleax addaleax force-pushed the cpplint-template branch from c4d3145 to 0a89353 Compare May 11, 2018 15:45
@tniessen
Copy link
Member

This needs to be rebased.

@addaleax addaleax force-pushed the cpplint-template branch from 0a89353 to bc7209d Compare May 13, 2018 15:17
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2018
@addaleax
Copy link
Member Author

Rebased, new CI: https://ci.nodejs.org/job/node-test-commit/18446/

@addaleax
Copy link
Member Author

Landed in bd6dc9e, fdfbf63

@addaleax addaleax closed this May 14, 2018
@addaleax addaleax deleted the cpplint-template branch May 14, 2018 16:11
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
src: replace template< → template <
bd6dc9e 
PR-URL: #20675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
tools: make C++ linter reject template<
fdfbf63 
This one is more or less just for me. :)

PR-URL: #20675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
src: replace template< → template <
28b58b5 
PR-URL: #20675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
tools: make C++ linter reject template<
44960a0 
This one is more or less just for me. :)

PR-URL: #20675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.