ACTION REQUIRED: workflow change for merging changes to nodejs/node

[orangemocha]

Based on previous discussion, feedback, and the approval by the TSC (#2434), we are adopting a new workflow for merging pull request in nodejs/node, and making any changes to the code branches at nodejs/node in general. The new workflow needs to be adopted by all @nodejs/collaborators for all changes to be merged to nodejs/node, starting this coming Monday at 2pm UTC: http://www.timeanddate.com/worldclock/fixedtime.html?msg=Start+merging+changes+to+nodejs%2Fnode+with+Jenkins&iso=20150831T14&p1=1440

From that time on, please refrain from pushing changes to nodejs/node manually, and instead use the workflow documented at /~https://github.com/nodejs/node/wiki/Merging-pull-requests-with-Jenkins. I also added a wiki page specifically on how to deal with flaky tests.

The workflow for testing (but not landing) pull requests with Jenkins is unchanged, and now documented here: /~https://github.com/nodejs/node/wiki/Testing-pull-requests-with-Jenkins

I'll be monitoring Jenkins to make sure things keep working smoothly. Let me and @nodejs/jenkins-admins know if you encounter any issues with the CI infrastructure or to share your feedback. Thank you!

[Fishrock123]

👍

[silverwind]

Do these merges add the committer line of whoever performed the merge?

[Fishrock123]

Do these merges add the committer line of whoever performed the merge?

I was told they will, and they need to for us to use it.

[orangemocha]

Do these merges add the committer line of whoever performed the merge?

Yes, the information is taken from your full name and email address as set in Jenkins. I will update the wiki to reflect that.

[ChALkeR]

What about documentation-only changes? I believe we don't yet have documentation-related tests, do we?

[orangemocha]

To ensure you committer info is set correctly, go to https://jenkins-iojs.nodesource.com/, login, click on your username on the top-right, then on the left click on 'Configure'. Double-check 'Full Name' and 'E-mail address'.

[orangemocha]

What about documentation-only changes? I believe we don't yet have documentation-related tests, do we?

Use node-accept-pull-request, and you can set NODES_SUBSET to pure_docs_changes to skip the tests. If we'll ever invent a way to test documentation, those tests will run as part of that configuration 😄

[ChALkeR]

On the left hand side, you should see "Build with parameters". If not, it probably means that you're not logged in. You need to be logged in to start this job.

Doesn't work for me. I am logged in and there is nothing like «Build with parameters». Can I have a screenshot?

I remeber it being ok in iojs+any-pr+multi.

[orangemocha]

[ChALkeR]

No, it's definitely not there.

[orangemocha]

@ChALkeR did you go to https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/ first ?

[ChALkeR]

@orangemocha Yes, of course.