doc: update the releaser onboarding process and rules #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
approved these changes
Nov 21, 2018
| promote the new GPG key to the user ecosystem prior to it being required to | ||
| verify an LTS release | ||
|
|
||
| ### SSH key guidance |
There was a problem hiding this comment.
This is great. I'd love a follow up with similar guidelines for gpg
MylesBorins
reviewed
Nov 21, 2018
|
ping @rvagg would you mind if I updated this based on the comments? |
|
yeah, sorry @MylesBorins, busy month. I'll get back to this soon but if you want to take over this you're more than welcome to. |
* guidance on SSH key complexity * notes about SSH & GPG key compromise * rules for starting new LTS releases (start with a Current)
MylesBorins
force-pushed
the
rvagg/update-add-releaser-process
branch
from
1ea33da to
dc998e0
Compare
|
I've rebased and updated. I kept the initial commit as identical to the original commit (modulo upstream changes)... made updates in a new comimt PTAL |
|
Worth mentioning this maintains the rule around having to promote a current release before LTS. We have had friction with this right now, but I also think that may be related to how many people we onboarded at once |
BethGriggs
approved these changes
Jan 23, 2019
targos
reviewed
Jan 31, 2019
targos
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming out of #390 I've done some updating of the process for adding new releasers.
Clean-up, plus I've Added:
The one thing I'm not sure about, but is already in here, is why all new releasers get added to nodejs-private? Perhaps that should be a separate step so as to give us more flexibility in adding releasers outside of the TSC while not expanding nodejs-private access too much. Security releases are a major ordeal and more important than even LTS releases to get right. And in practice, very few of us even do them because of the massive workload and complexity involved—and past experimentation with multiple releasers coordinating hasn't gone well. Happy to leave this in here for now but it might be worth discussing.
/cc @nodejs/release, @nodejs/releasers & @nodejs/build