fix(http): allow tokens to exceed 20 chars

[max-wittig]

GitLab allows users of an instance to specify a token prefix since 13.8, which is where this current assumption breaks down

See: https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#personal-access-token-prefix

[max-wittig]

@mapret Thanks for the initial review! Pipeline should be green now. Would you mind to take another look?

[max-wittig]

@mapret Care to review again? This library is currently not working for people on our instance

[mapret]

@max-wittig Looks good to me, but I am not a maintainer of this project, I am just the one who opened the related issue on our internal GitLab 😉.

[max-wittig]

@jetersen @nmklotas Would you mind to take a look?

[jetersen]

I think it would be better to distinguish between bearer token and PAT via two properties.
That way the switch can go away and there will be no need to throw exception.

FYI you can write the same if statements as a switch case, so there was no need to change the entire signature.

[max-wittig]

@jetersen thanks for the review. What do you mean by properties? Attributes that the user specifies? I'm not really into C# and this was ment as a bit of a quick fix so I'm not too familiar with all the details of the language.

[wwwjon]

I came across this pull request because I encountered the same issue and I'm very interested that this issues is fixed as soon as possible. So I would like to help, but unfortunately I don't understand either exactly how @jetersen imagined it with properties.

@jetersen Could you explain this in more detail?

[max-wittig]

@jetersen Using switch again now. Could you please take another look?

[fgreinacher]

@jetersen @nmklotas Mind having another look at this? We're also running in the underlying issue 😀

[jetersen]

released in 1.8.0