Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAX output locale-independent #4505

Merged
merged 19 commits into from
Nov 24, 2024
Merged

Make SAX output locale-independent #4505

merged 19 commits into from
Nov 24, 2024

Conversation

nlohmann
Copy link
Owner

Closes #4084

@nlohmann nlohmann self-assigned this Nov 20, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 20, 2024
@github-actions github-actions bot added the M label Nov 20, 2024
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Nov 20, 2024
@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 99.647% (-0.4%) from 100.0%
when pulling 6c73927 on fix-locale
into 378e091 on develop.

Copy link
Owner Author

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • add a test suite for locale-dependent issues

@github-actions github-actions bot added L tests and removed M labels Nov 21, 2024
Copy link

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @nlohmann
Please read and follow the Contribution Guidelines.

1 similar comment
Copy link

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @nlohmann
Please read and follow the Contribution Guidelines.

@github-actions github-actions bot added the CI label Nov 22, 2024
@nlohmann nlohmann removed the review needed It would be great if someone could review the proposed changes. label Nov 24, 2024
@nlohmann nlohmann merged commit ee32bfc into develop Nov 24, 2024
128 checks passed
@nlohmann nlohmann deleted the fix-locale branch November 24, 2024 20:14
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🐛 make SAX output locale-independent nlohmann#4084

* ✅ add test

* ✅ add test

* ✅ add test

* ✅ add test

* ✅ add test

* ✅ add test

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084

* 🐛 make SAX output locale-independent nlohmann#4084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAX interface unexpectedly gets locale-altered float representation.
4 participants