Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows arm64 binaries #87

Closed
aivarannamaa opened this issue Nov 30, 2024 · 2 comments · Fixed by #92
Closed

Add Windows arm64 binaries #87

aivarannamaa opened this issue Nov 30, 2024 · 2 comments · Fixed by #92

Comments

@aivarannamaa
Copy link

Since version 20 (or at least 20.18.1) Node.js publishes binaries for Windows Arm64 architecture. Could you please upload these as well?

@njzjz
Copy link
Owner

njzjz commented Dec 2, 2024

I will try it after nodejs/build#3963 is fixed with the GitHub Actions. Note that in this repository, binaries are rebuilt instead of just reuploading the official binaries.

njzjz added a commit that referenced this issue Dec 5, 2024
Fix #87.

Add support for Windows ARM64 cross-compilation.

* **CMakeLists.txt**
  - Add a new `elseif` block for `WIN32 AND CMAKE_SYSTEM_PROCESSOR STREQUAL "ARM64"` to handle Windows ARM64 builds.
  - Set the `BUILD_COMMAND` to `./vcbuild arm64` for Windows ARM64 builds.
  - Set the `INSTALL_COMMAND` to an empty string for Windows ARM64 builds.
  - Add an `install` command to copy the `node.exe` file to the appropriate destination for Windows ARM64 builds.
  - Add an `install` command to copy the `npm` directory to the appropriate destination for Windows ARM64 builds.

* **.github/workflows/build_wheel.yml**
  - Add a new matrix entry for Windows ARM64 builds with `os: windows-latest` and `platform_id: win_arm64`.
  - Add a condition to the `ilammy/setup-nasm@v1` step to include `matrix.platform_id == 'win_arm64'`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/njzjz/nodejs-wheel?shareId=XXXX-XXXX-XXXX-XXXX).
njzjz added a commit that referenced this issue Dec 6, 2024
Fix #87.

Add support for Windows ARM64 cross-compilation.

* **CMakeLists.txt**
- Add a new `elseif` block for `WIN32 AND CMAKE_SYSTEM_PROCESSOR
STREQUAL "ARM64"` to handle Windows ARM64 builds.
- Set the `BUILD_COMMAND` to `./vcbuild arm64` for Windows ARM64 builds.
- Set the `INSTALL_COMMAND` to an empty string for Windows ARM64 builds.
- Add an `install` command to copy the `node.exe` file to the
appropriate destination for Windows ARM64 builds.
- Add an `install` command to copy the `npm` directory to the
appropriate destination for Windows ARM64 builds.

* **.github/workflows/build_wheel.yml**
- Add a new matrix entry for Windows ARM64 builds with `os:
windows-latest` and `platform_id: win_arm64`.
- Add a condition to the `ilammy/setup-nasm@v1` step to include
`matrix.platform_id == 'win_arm64'`.

---

For more details, open the [Copilot Workspace
session](https://copilot-workspace.githubnext.com/njzjz/nodejs-wheel/pull/91?shareId=127f29b4-7a5a-4aeb-882f-a853583447a7).

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz closed this as completed in #92 Dec 6, 2024
njzjz added a commit that referenced this issue Dec 6, 2024
Fix #87.

Add support for Windows ARM64 cross-compilation.

* **CMakeLists.txt**
- Add a new `elseif` block for `WIN32 AND CMAKE_SYSTEM_PROCESSOR
STREQUAL "ARM64"` to handle Windows ARM64 builds.
- Set the `BUILD_COMMAND` to `./vcbuild arm64` for Windows ARM64 builds.
- Set the `INSTALL_COMMAND` to an empty string for Windows ARM64 builds.
- Add an `install` command to copy the `node.exe` file to the
appropriate destination for Windows ARM64 builds.
- Add an `install` command to copy the `npm` directory to the
appropriate destination for Windows ARM64 builds.

* **.github/workflows/build_wheel.yml**
- Add a new matrix entry for Windows ARM64 builds with `os:
windows-latest` and `platform_id: win_arm64`.
- Add a condition to the `ilammy/setup-nasm@v1` step to include
`matrix.platform_id == 'win_arm64'`.

---

For more details, open the [Copilot Workspace

session](https://copilot-workspace.githubnext.com/njzjz/nodejs-wheel/pull/91?shareId=127f29b4-7a5a-4aeb-882f-a853583447a7).

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@aivarannamaa @njzjz and others