Allow use of SignalFd through shared reference #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zopsicle
force-pushed
the
signalfd-no-mut
branch
from
acad132 to
1c3c97d
Compare
SteveLauC
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
LGTM! Thanks!
It looks like these interfaces take mutable references since they were introduced to Nix, that was 9 years ago: 36432e1#diff-334c9af19669019c937e142276a7b1edf82495d5c5b2fba3351b0a56d041892b
|
Could you please rebase your branch, the CI failure should be fixed in #2368 |
Like with many other file descriptors, concurrent use of signalfds is safe. Changing the signal mask of and reading signals from a signalfd can now be done with the `SignalFd` API even if other references to it exist. Fixes nix-rust#2366.
zopsicle
force-pushed
the
signalfd-no-mut
branch
from
1c3c97d to
1bcdcdf
Compare
|
Rebased on latest master. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with many other file descriptors, concurrent use of signalfds is safe. Changing the signal mask of and reading signals from a signalfd can now be done with the
SignalFdAPI even if other references to it exist.Fixes #2366.
What does this PR do
Checklist:
CONTRIBUTING.md