Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: change stateVersion check for compatiblity #6453

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

khaneliman
Copy link
Collaborator

Original change was created before 24.11 release. We are in 25.05 now.

Follow up to #5516

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Original change was created before 24.11 release. We are in 25.05 now.
@khaneliman khaneliman merged commit 6d3163a into nix-community:master Feb 14, 2025
3 checks passed
@khaneliman khaneliman deleted the gitfix branch February 14, 2025 22:21
@sumnerevans
Copy link
Member

Whoops, thanks!

@wzxu
Copy link

wzxu commented Feb 16, 2025

I'm still not quite sure how stateVersion works, but I'm currently using stateVersion = "25.05" and I suppose this would fix my failing build due to error: The option `home-manager.users.wzxu.programs.git.signing.format' was accessed but has no value defined. Try setting the option., but it still fails the same.

Do I have to set this option even if I'm not using signing? Or should I not use stateVersion = "25.05" at all? Thanks.

tetov pushed a commit to tetov/home-manager that referenced this pull request Feb 16, 2025
Original change was created before 24.11 release. We are in 25.05 now.
347Online pushed a commit to 347Online/home-manager that referenced this pull request Mar 1, 2025
Original change was created before 24.11 release. We are in 25.05 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants