-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Clean-up the BaseInterface run()
function using context
#3347
Conversation
Python contexts seem the most appropriate pattern to follow.
Codecov Report
@@ Coverage Diff @@
## master #3347 +/- ##
==========================================
+ Coverage 65.08% 65.11% +0.02%
==========================================
Files 307 307
Lines 40362 40373 +11
Branches 5329 5326 -3
==========================================
+ Hits 26270 26288 +18
+ Misses 13019 13014 -5
+ Partials 1073 1071 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I've been noticing that under some (yet unknown) conditions, the node report after a crash will show definitely set inputs as undefined, and some errors that escape generating a crash file. This PR, in collaboration with #3349, makes the flow of operations a bit more clear and makes the treatment of errors more reliable. |
To note, I have tested this and #3349 locally with fMRIPrep and dMRIPrep and they seem to work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some things to discuss about exceptions.
d78d434
to
24f2cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too.
run()
function using contextrun()
function using context
Python contexts seem the most appropriate pattern to follow.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment