-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve version checking for nodes of workflows #3152
Conversation
What if we add a new environment variable like |
Codecov Report
@@ Coverage Diff @@
## maint/1.4.x #3152 +/- ##
==============================================
+ Coverage 67.54% 67.6% +0.05%
==============================================
Files 299 299
Lines 39499 39496 -3
Branches 5220 5220
==============================================
+ Hits 26681 26701 +20
+ Misses 12108 12087 -21
+ Partials 710 708 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic is backwards in a couple places, and I'm a bit confused by the pyscript
stuff.
This seems to work. See satra#31 for a test and a couple small suggestions. Also, we currently support two other environment variables: |
Only remaining comment is that, as a bug fix, we should target Edit: Failing test fixed in |
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
71e0696
to
e2db192
Compare
@satra Rebased cleanly, so I just force-pushed to keep this moving. Hope that's okay. |
Reduce number of version checks for nodes of workflows run through multiprocessing .
This is a rather drastic step, and we should think through how to handle this in general. this will prevent this for other libraries which are used as well.