Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Can't seem to import workflows from niflows in CircleCI #3134

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Jan 2, 2020

Master is broken -- this PR relocates the pip install of
niflow-nipype1-workflows so that it happens AFTER nipype
was installed.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@oesteban
Copy link
Contributor Author

oesteban commented Jan 2, 2020

Blocked by niflows/nipype1-workflows#5

@satra
Copy link
Member

satra commented Jan 2, 2020

@oesteban - merged do we need to make a new release there first?

i don't know if @effigies did the release manually or through travis or some combination. i do see twine is being installed.

@oesteban
Copy link
Contributor Author

oesteban commented Jan 2, 2020

@effigies
Copy link
Member

effigies commented Jan 2, 2020

Oh, yeah, it's manual. Give me a minute to release.

@effigies
Copy link
Member

effigies commented Jan 2, 2020

Pushed to PyPI.

Master is broken -- this PR relocates the pip install of
``niflow-nipype1-workflows`` so that it happens AFTER nipype
was installed.
@oesteban oesteban force-pushed the fix/old-workflows-missing branch from ea58a71 to bc566b5 Compare January 2, 2020 22:43
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #3134 into master will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
- Coverage   64.84%   63.96%   -0.88%     
==========================================
  Files         299      297       -2     
  Lines       39480    39399      -81     
  Branches     5220     5210      -10     
==========================================
- Hits        25599    25202     -397     
- Misses      12829    13154     +325     
+ Partials     1052     1043       -9
Flag Coverage Δ
#unittests 63.96% <ø> (-0.88%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/epi.py 62.08% <ø> (ø) ⬆️
nipype/sphinxext/plot_workflow.py 13.79% <ø> (ø) ⬆️
nipype/interfaces/nilearn.py 38.98% <0%> (-57.63%) ⬇️
nipype/utils/spm_docs.py 20% <0%> (-48%) ⬇️
nipype/interfaces/freesurfer/base.py 45.68% <0%> (-30.18%) ⬇️
nipype/utils/logger.py 58.46% <0%> (-27.7%) ⬇️
nipype/testing/fixtures.py 76.38% <0%> (-22.23%) ⬇️
nipype/interfaces/matlab.py 63.91% <0%> (-12.38%) ⬇️
nipype/interfaces/dcm2nii.py 48.82% <0%> (-9.86%) ⬇️
nipype/interfaces/spm/base.py 57.66% <0%> (-9.67%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c9ace...bc566b5. Read the comment docs.

@oesteban
Copy link
Contributor Author

oesteban commented Jan 2, 2020

Thx!

@oesteban oesteban merged commit ec5e74f into nipy:master Jan 3, 2020
@oesteban oesteban deleted the fix/old-workflows-missing branch January 3, 2020 01:56
@effigies effigies added this to the 1.4.1 milestone Jan 6, 2020
@effigies effigies mentioned this pull request Jan 6, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants