Add doctype: RST|Markdown|RstMarkdown pragma
#20252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements nim-lang/RFCs#68 , see also discussion in nim-lang#17987 The permitted values: * `markdown`, which is default. It still contains nearly all of the RST supported but it is assumed that in time we will give up most or all RST features in this mode * `rst`, without any extensions * `RstMarkdown` — compatibility with Nim 1.x. It's basically RST with those Markdown features enabled that don't conflict with RST.
Varriount
reviewed
Aug 21, 2022
Co-authored-by: Clay Sweetser <Varriount@users.noreply.github.com>
|
Since the RFC has been merged, I'm merging this. |
Varriount
approved these changes
Aug 23, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* Add `doctype: RST|Markdown|RstMarkdown` pragma Implements nim-lang/RFCs#68 , see also discussion in nim-lang#17987 The permitted values: * `markdown`, which is default. It still contains nearly all of the RST supported but it is assumed that in time we will give up most or all RST features in this mode * `rst`, without any extensions * `RstMarkdown` — compatibility with Nim 1.x. It's basically RST with those Markdown features enabled that don't conflict with RST. * Apply suggestions from code review Co-authored-by: Clay Sweetser <Varriount@users.noreply.github.com> * Additional fix in spirit of review * Fix test after nim-lang#20188 Co-authored-by: Clay Sweetser <Varriount@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements nim-lang/RFCs#68 , see also discussion in #17987
doctypesets markup language on a module level.The permitted values:
markdown, which is default. It still contains nearly all of the RST supported but it is assumed that in time we will give up most or all RST features in this moderst, without any Markdown extensionsRstMarkdown— for compatibility with Nim 1.x. It's basically RST with those Markdown features enabled that don't conflict with RST.