Markdown: allow to end URL with balanced parenthesis #18321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1246,15 +1246,44 @@ proc isUrl(p: RstParser, i: int): bool = | |||
| p.tok[i+3].kind == tkWord and | |||
| p.tok[i].symbol in ["http", "https", "ftp", "telnet", "file"] | |||
|
|
|||
| proc checkParen(token: Token, parensStack: var seq[char]): bool {.inline.} = | |||
There was a problem hiding this comment.
completely optional: can you split this into a more general reusable proc and then call it, and then in future work we can move this reusable proc to strbasics or strutils? (similar to https://dlang.org/library/std/algorithm/searching/balanced_parens.html, and same functionality as what you have)
proc balancedParens(a: openArray[char], parensStack: var seq[char]): bool =
# xxx in future work, move to stdlib
proc checkParen(token: Token, parensStack: var seq[char]): bool {.inline.} =
call balancedParens somehowThere was a problem hiding this comment.
The idea of balancedParens is very different: it check whether parens are balanced or not.
checkParen does not always forbid unbalanced parens: e.g. ([) and (]) are legal, and checkParen will return 3 values False,False,True in both cases for 3 tokens.
Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
Araq
reviewed
Jun 22, 2021
lib/packages/docutils/rst.nim
Outdated
| if c in {'(', '[', '{'}: # push | ||
| parensStack.add c | ||
| elif c in {')', ']', '}'}: # try pop | ||
| if parensStack.len > 0: |
There was a problem hiding this comment.
Pointless if statement, if the collection is empty the loop will iterate 0 times.
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* Markdown: allow to end URL with balanced parenthesis * Update lib/packages/docutils/rst.nim Co-authored-by: Timothee Cour <timothee.cour2@gmail.com> * apply suggestion * remove unnecessary if Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes bug 24 from #17340 (except escaping).
cc @timotheecour