-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update omnixxx submodules trio #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran this in-vivo multiple days. LGTM.
This PR was updated to include 2 additional PR for OmniBLE and OmniKit. See OmniBLE PR 139 and OmniKit PR 47 |
Add recent fix to the OmniXXX submodules to prevent 0x31 (decimal 049) faults. See this issue and these two PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, running several days in-vivo aswell
Update:
Additional OmniBLE/OmniKit updates were added to this PR. One of them prevents a critical fault that can lead to unnecessary loss of a pod.
Purpose:
These improvements for OmniBLE/OmniKit are brought into trio. Most of the work was done by @itsmojo. I prepared the fix for Eros in which the clock icon was not provided when time zone does not match between phone and pod.
OmniBLE 4ad8117...fee22b3 (5):
OmniKit 01bc598...0857ad8 (3):
For additions to the PR, see:
LoopKit/OmniBLE#139 and LoopKit/OmniKit#47
Trio Issue 455
LoopKit/OmniBLE#140
LoopKit/OmniKit#48
Status:
These have all been merged into LoopKit/OmniBLE:dev and LoopKit/OmniKit:main as well as the loopandlearn:OmniXXX:trio branch.
Testing: