Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing / un-registering hotkeys #6

Closed
alvaromartmart opened this issue Jun 12, 2020 · 2 comments
Closed

Removing / un-registering hotkeys #6

alvaromartmart opened this issue Jun 12, 2020 · 2 comments

Comments

@alvaromartmart
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Hotkeys can be added programatically using HotkeyService.addShortcut, but they can't be un-registered.

Expected behavior

A HotkeyService.removeShortcut allowing to delete shortcuts would be nice.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

I'm using the library to implement a functionality where the users can assign hotkeys to specific actions. This is done through a custom service that keeps track of keyboard assignments, so I need a way to un-register hotkeys.

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@NetanelBasal
Copy link
Member

Sure. Do you want to submit a PR?

@alvaromartmart
Copy link
Contributor Author

Sure! I think I can come up with something in a couple of days, I'll keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants