Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nf-test tests for local modules and subworkflows #123

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Add nf-test tests for local modules and subworkflows #123

merged 11 commits into from
Jan 15, 2025

Conversation

fbdtemme
Copy link
Collaborator

@fbdtemme fbdtemme commented Jan 14, 2025 •
edited
Loading

  • Add local and subworfklow tests.
  • Add stubs for all modules
  • Fix some missing version reporting
  • Add sharded nf-test CI/CD taken from nf-core/sarek

Depends on: nf-core/test-datasets#1458

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4082811

+| ✅ 223 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.0
  • files_unchanged - LICENSE does not match the template
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.1
  • Run at 2025-01-15 14:54:42

@fbdtemme fbdtemme marked this pull request as ready for review January 15, 2025 14:18
johandahlberg
johandahlberg approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@johandahlberg johandahlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Nice to learn about the stub thing. I hadn't seen that before.

@fbdtemme fbdtemme merged commit c7c60a0 into dev Jan 15, 2025
34 checks passed
@fbdtemme fbdtemme deleted the add-tests branch January 15, 2025 15:17
@fbdtemme fbdtemme mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johandahlberg johandahlberg johandahlberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @johandahlberg