update NORM meta in abundance_differential_filter

[suzannejin]

Just a small change, to use a meta for deseq2_norm and limma_norm that does not contain contrast info (since they are irrelevant here).

PR checklist

Closes #XXX

• This comment contains a description of changes (with reason).
• If you've fixed a bug or added code that should be tested, add tests!
• If you've added a new tool - have you followed the module conventions in the contribution docs
• If necessary, include test data in your PR.
• Remove all TODO statements.
• Emit the versions.yml file.
• Follow the naming conventions.
• Follow the parameters requirements.
• Follow the input/output options guidelines.
• Add a resource label
• Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • For modules:
    • nf-core modules test <MODULE> --profile docker
    • nf-core modules test <MODULE> --profile singularity
    • nf-core modules test <MODULE> --profile conda
  • For subworkflows:
    • nf-core subworkflows test <SUBWORKFLOW> --profile docker
    • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
    • nf-core subworkflows test <SUBWORKFLOW> --profile conda

[pinin4fjords]

Unless I'm missing something (always possible), I think what you're doing here is making the _NORM modules run for EVERY combination of contrasts and matrix etc, rather than just the first contrast.

[pinin4fjords]

Surely this will have LIMMA_NORM run for EVERY contrast?

[suzannejin]

You are right! I put norm_inputs back, now it should be fine, it should only compute NORM as many times as unique meta_input have.
The reason I use unique() instead of first() is to make sure that the ch_inputs coming with different meta (eg. args) will not be ignored.

[pinin4fjords]

Actually, I think we should just lose .first(), it was a hangover from before our iterations and I should have removed it before. Don't think we need unique either. The whole idea of the .combine()s is to generate all the combinations we need.

[suzannejin]

Now the code should be fine! I also added def meta inside the multimap criteria, because otherwise the two iterations sometimes mix up.

[pinin4fjords]

Looking good