Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace OC_App calls by IAppManager #50999

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fix: Replace OC_App calls by IAppManager #50999

merged 4 commits into from
Feb 27, 2025

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 24, 2025 •
edited
Loading

  • Resolves: #

Summary

Migrate some more calls from OC_App to IAppManager.

Checklist

@come-nc come-nc added the 2. developing Work in progress label Feb 24, 2025
@come-nc come-nc self-assigned this Feb 24, 2025
@come-nc come-nc force-pushed the fix/move-away-from-oc-app branch from 52bd11b to fe90292 Compare February 24, 2025 16:47
@come-nc
fix: Replace OC_App calls by IAppManager
3413998 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(tests): Adapt tests to appManager usage
e2a4649 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Clean up OC_App usage in public.php
3a6345a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Remove incorrect @throws annotations and move away from OC_App
d189ed3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/move-away-from-oc-app branch from fe90292 to d189ed3 Compare February 24, 2025 16:48
@come-nc come-nc added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels Feb 24, 2025
@come-nc come-nc added this to the Nextcloud 32 milestone Feb 24, 2025
@come-nc come-nc requested review from susnux, a team, Altahrim, artonge and nfebe and removed request for a team February 24, 2025 16:49
@come-nc come-nc marked this pull request as ready for review February 24, 2025 16:50
st3iny
st3iny reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalDAV changes look good.

artonge
artonge reviewed Feb 25, 2025
View reviewed changes
@come-nc come-nc requested a review from artonge February 27, 2025 13:46
@come-nc come-nc enabled auto-merge February 27, 2025 17:12
@come-nc come-nc merged commit 001b12c into master Feb 27, 2025
194 checks passed
@come-nc come-nc deleted the fix/move-away-from-oc-app branch February 27, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny left review comments

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @st3iny @susnux @artonge