fix(files): Ensure the filter instance is mounted #50919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable31 |
artonge
approved these changes
Feb 20, 2025
skjnldsv
approved these changes
Feb 20, 2025
susnux
force-pushed
the
fix/type-error-filter-mount
branch
from
5aff466 to
c200bc6
Compare
|
/compile |
susnux
force-pushed
the
fix/type-error-filter-mount
branch
from
aba0651 to
810c878
Compare
|
🚀 |
`reset` could be called before the filters are mounted, in this case it is valid to update the presets, but we must not try to access the vue instance (as it does not exist yet). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
prevent filters not applied if `filtersChanged` was set before file list mounted. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
fix/type-error-filter-mount
branch
from
810c878 to
8b16c84
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resetcould be called before the filters are mounted, in this case it is valid to update the presets, but we must not try to access the vue instance (as it does not exist yet).Fixes:
Checklist