[stable30] fix(files): Do not download files with openfile query flag #50706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](/~https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
susnux
approved these changes
Feb 6, 2025
susnux
force-pushed
the
backport/50669/stable30
branch
from
ee466c2 to
0cf5bba
Compare
AndyScherzinger
approved these changes
Feb 6, 2025
|
merge to be aligned with release team |
Instead of downloading files, if there is no other default action, we should just open the details tab. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/50669/stable30
branch
from
0cf5bba to
29348ef
Compare
skjnldsv
reviewed
Feb 19, 2025
| // in this case we need to open the details instead and remove the route from the history | ||
| const query = this.$route.query | ||
| delete query.openfile | ||
| query.opendetails = '' |
There was a problem hiding this comment.
@susnux this should have been removed 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50669
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.